flux positivity constraint

benjaminpope / drpangloss

the best of all possible interferometry models

https://benjaminpope.github.io/drpangloss/

MIT License

2 stars 0 forks source link

flux positivity constraint #23

Open benjaminpope opened 4 months ago

benjaminpope commented 4 months ago

It is a well-known phenomenon that for a real binary signal, the best fitting binary has positive flux on one side and negative on another.

Here is AB Dor:

It looks bad because after optimization it is negative on one side and positive on the other. I think we should do this calculation in log flux so that it is strictly positive, but I wanted to check @shashankdholakia and @LouisDesdoigts agree.

LouisDesdoigts commented 3 months ago

Yeah I can't see why not (beyond maybe the negative flux plot looking cooler)