search

benjaminrose / SN-with-Roman-Prism

Characterizing SN Observations with the Roman ST Prism
0 stars 0 forks source link

Packaged embed2spec; remove submodule and update installation instructions #3

Closed sam-dixon closed 3 years ago

sam-dixon commented 3 years ago

I updated embed2spec so that it is a proper python package that you can install with pip install git+https://github.com/sam-dixon/embed2spec.git. This obviates the need for using submodules. In this PR, I removed the submodule, updated the installation instructions, and updated the imports in embed2roman.py to reflect these changes. This should also resolve Issue #2.

benjaminrose commented 3 years ago

Well, this may make a fun merge with my local mess.

sam-dixon commented 3 years ago

I didn't realize I could add git installs to environment.yml files! Just did in the latest commit and removed the redundant installation instructions.

benjaminrose commented 3 years ago

Yeah, anything under the - pip is just passed to pip install.