search

benjaminws / stomp-js

Implementation of the STOMP protocol in node.js
BSD 3-Clause "New" or "Revised" License
87 stars 47 forks source link

Why the body is always part of the header #5

Closed chitomanansala closed 13 years ago

chitomanansala commented 13 years ago

Hi Benjamin, I noticed that the body attribute is always put as part of the message header when you use the stomp.send function. How can you ensure that message body should not be added in the header?

client.send({ 'corellationid': '4376423-42384793274923-42423', 'destination': queue, 'persistent': 'true', 'body': datatoSend, }, false );

here is the output

{ command: 'MESSAGE', headers: [ body: '<?xml version="1.0" encoding="UTF-8"?> cfe1', 'message-id': 'ID:ctovm921-44693-1305919160222-4:148:-1:1:1', corellationid: '4376423-42384793274923-42423', destination: '/queue/BRUTUS.MTX', timestamp: '1306191865238', expires: '0', session: 'ID:ctovm921-44693-1305919160222-4:148', priority: '4' ], body: '<?xml version="1.0" encoding="UTF-8"?> cfe1\u0000\n' }

benjaminws commented 13 years ago

Ill take a look at this ASAP.

On May 23, 2011 7:14 PM, "chitomanansala" < reply@reply.github.com> wrote:

Hi Benjamin, I noticed that the body attribute is always put as part of the message header when you use the stomp.send function. How can you ensure that message body should not be added in the header?

client.send({ 'corellationid': '4376423-42384793274923-42423', 'destination': queue, 'persistent': 'true', 'body': datatoSend, }, false );

here is the output

{ command: 'MESSAGE', headers: [ body: '<?xml version="1.0" encoding="UTF-8"?> <AuthenticateRQ

cfe1', 'message-id': 'ID:ctovm921-44693-1305919160222-4:148:-1:1:1', corellationid: '4376423-42384793274923-42423', destination: '/queue/BRUTUS.MTX', timestamp: '1306191865238', expires: '0', session: 'ID:ctovm921-44693-1305919160222-4:148', priority: '4' ], body: ' cfe1\u0000\n' }

Reply to this email directly or view it on GitHub: https://github.com/benjaminws/stomp-js/issues/5

benjaminws commented 13 years ago

At a quick glance from my phone it looks like when the frame is built in frame.js, I'm not popping off the body arg, which is part of the "args" object passed to Frame.build_frame. I'll fix it this evening and and update the issue.

On May 23, 2011 7:58 PM, "Benjamin Smith" benjaminwarfield@just-another.net wrote:

Ill take a look at this ASAP.

On May 23, 2011 7:14 PM, "chitomanansala" <reply+i-944210-c86644d1e83e47cc6ad1823e884e55a4418e6...

benjaminws commented 13 years ago

Can you try the test-delete-body branch and see if that fixes it for you?

chitomanansala commented 13 years ago

I tried the simple fix and it worked. Thanks

benjaminws commented 13 years ago

Thanks for your report. I'm merging the fix in to master and releasing a package now.