search

benjamn / ast-types

Esprima-compatible implementation of the Mozilla JS Parser API
MIT License
1.13k stars 195 forks source link

Does `TSTypeParameter.name` need to be all of `IdentifierKind` types? #939

Open smurzin opened 1 year ago

smurzin commented 1 year ago

It seems that in recent version TSTypeParameter.name has been extended to be string | K.IdentifierKind.

This results in a weird type cycle, where a name can be any identifier including TSTypeParameter again. Causing client code to deal with it somehow. It seems that babel-parser tests do not have any examples of generating anything apart from plain Identifier (or string) for TStypeParameter.name.

Should this be constrained a bit more?