Open MichaelDeBoey opened 2 years ago
When we got this problem in the remix repo (https://github.com/remix-run/remix/pull/3987), I reported this in the jscodeshift repo (https://github.com/facebook/jscodeshift/issues/520), but since all their builders are coming from recast, I thought it would be a good idea to also report it in this repo
remix
jscodeshift
recast
For some reason Windows is throwing an error when converting a FunctionDeclaration to a FunctionExpression, while this is perfectly working (as expected) on Linux. As @mcansh pointed out in https://github.com/remix-run/remix/pull/3987#issuecomment-1218239753, the origin of this problem is coming from ast-types https://github.com/benjamn/ast-types/blob/master/lib/types.ts#L656-L658 AST Explorer example (which is failing as well): https://astexplorer.net/#/gist/31f7305e1a29c0565f6efb13709e93a8/latest
For some reason Windows is throwing an error when converting a FunctionDeclaration to a FunctionExpression, while this is perfectly working (as expected) on Linux.
FunctionDeclaration
FunctionExpression
As @mcansh pointed out in https://github.com/remix-run/remix/pull/3987#issuecomment-1218239753, the origin of this problem is coming from ast-types https://github.com/benjamn/ast-types/blob/master/lib/types.ts#L656-L658
ast-types
AST Explorer example (which is failing as well): https://astexplorer.net/#/gist/31f7305e1a29c0565f6efb13709e93a8/latest
@benjamn If you can point me into the right direction, I would be happy to create a PR to fix this.
When we got this problem in the
remix
repo (https://github.com/remix-run/remix/pull/3987), I reported this in thejscodeshift
repo (https://github.com/facebook/jscodeshift/issues/520), but since all their builders are coming fromrecast
, I thought it would be a good idea to also report it in this repo