esprima-fb → esprima?

mathiasbynens commented 9 years ago

https://github.com/benjamn/recast/blob/24ebc0e110aed78326fc1278d888912c4a53cb7b/package.json#L28

Now that esprima-fb is being deprecated (https://github.com/facebook/esprima/issues/111), will recast switch to regular Esprima instead?

benjamn commented 9 years ago

Yes, I think I would like to run the test suite using both https://github.com/jquery/esprima and https://github.com/marijnh/acorn. Any other suggestions?

mathiasbynens commented 9 years ago

There’s also https://github.com/eslint/espree.

danieljuhl commented 9 years ago

babel-core?

cpojer commented 9 years ago

I think https://github.com/babel/acorn-babel would be a good contender, despite the README saying it is not supported outside of babel. Babel is quickly becoming a transpiler standard.

fkling commented 9 years ago

@cpojer: I don't think that project is kept up-to-date anymore. The acorn fork/extension seems to be kept inside babel-code.

fkling commented 9 years ago

@benjamn: Is there any progress on supporting different parsers? If you are busy, maybe you could outline what needs to be done so that's easier for others to help?

benjamn commented 9 years ago

In principle, recast.parse(source, { esprima: require("any/parser/you/like") }) should work already for any sufficiently Esprima-like parser module (including Acorn AFAIK), so it should be just a matter of actually running tests using different parsers to provide more confidence there?

If you have time to take a look at the test runner to use other parsers, that would be great!

benjamn commented 9 years ago

Specifically, I would add other parsers to devDependencies in package.json, then allow the test suite to require a different parser based on an environment variable like process.env.PARSER_MODULE_ID, then add a npm script called test-all-parsers that invokes (at least the parser-related) tests for every parser. That comprehensive test should be what runs in Travis CI, though it's fine if the ordinary npm test command just uses the default parser.

This testing might reveal that more pretty-printer cases need to be added to lib/printer.js, but that work should be minimal.

nene commented 8 years ago

It's been a while and esprima-fb is still deprecated. Should Recast also be considered as deprecated?

Like, I'm trying to parse this code:

function fn({foo={}} = {}) { }

...and Recast simply blows up because esprima-fb is unable to handle it. Official Esprima parses it just fine though.

fkling commented 8 years ago

@nene: you can always pass another parser to recast via the esprima option. But I agree that recast should upgrade to another default parser or not provide a default at all (which would be a breaking change though).

nene commented 8 years ago

Ah... thanks. I wasn't aware of such an option... or really the existence of any options as these are only documented inside the source.