search

benjaoming / django-relatedadminwidget

AS OF DJANGO 1.9 THIS PROJECT IS UNNECESSARY! Widget for displaying edit and delete links alongside foreign key admin widgets
40 stars 9 forks source link

Running pip install upgrades django to 1.4 #1

Closed andybak closed 12 years ago

andybak commented 12 years ago

Which wasn't what I wanted on my nice Django 1.3 project.

benjaoming commented 12 years ago

Hi can you test if it works now? I have changed the dependency to django 1.3 but I haven't tested it.

d594393a0f9ad1801469d8cf0aa50bc94ad1c55f

andybak commented 12 years ago

My point was that it shouldn't have Django as a dependency, should it?

No-one is going to install this unless they are already have Django installed.

benjaoming commented 12 years ago

It won't work on any django version... check the source code. I'm not sure, but I think it breaks on 1.2 -- and it might break in 1.5, so that would just produce a dependency that said django>=1.3 and django<1.5 -- this is normal to state in any django app.

wardk commented 9 years ago

Django got upgraded from 1.7 to 1.7.1 with me. I agree with andybak: it's not what you expect. Unless all django addons do this, i think it's better to drop the django dependency.

benjaoming commented 9 years ago

You have probably been running pip install django-relatedadminwidget --upgrade ? You should ask pip explicitly to not try to update django in this circumstance. I mean, I could completely remove the Django dependency, but that would also remove the requirement of Django>=1.3.. this is common practice.

To upgrade without upgrading django, you can run pip install django-relatedadminwidget django\<=1.7 --upgrade