search

benjaoming / django-relatedadminwidget

AS OF DJANGO 1.9 THIS PROJECT IS UNNECESSARY! Widget for displaying edit and delete links alongside foreign key admin widgets
40 stars 9 forks source link

replace .live by .on in jquery #6

Closed wardk closed 9 years ago

wardk commented 9 years ago

Deprecated 'live' function (http://api.jquery.com/live/) in relatedwidget.js caused javascript error, breaking the grappelli interface i'm using. I understand it's a jquery version issue. It could solve it quite easily by replacing the two live() function calls on lines 36 and 48 by on()

benjaoming commented 9 years ago

Acknowledged, can you make a PR for that? :) I'll make sure to release an update on pypi after.

wardk commented 9 years ago

Not familiar with github, sry. While trying to create the PR, i found that joelcrocker already made the edit a year ago. I installed with pip, few months ago, guess that package was outdated.

benjaoming commented 9 years ago

Oh cool, I didn't know! Can you test the latest 0.0.3 release and see if it works? I've put it on PyPi so you can pip install django-relatedadminwidget -- setup.py produces some warnings, but shouldn't matter...

wardk commented 9 years ago

Did a pip3 install -U django-relatedadminwidget; files are updated and everything seems to work fine.

benjaoming commented 9 years ago

Great! But wait, you're running python3? Does it work with python3?? :)

wardk commented 9 years ago

Yup, i'm thinking you weren't specifically aiming for it? Given that it's mostly JavaScript and template, and django not being any different, i guess there's no reason why it wouldn't work... Anyway, it's mighty useful, i can't understand why it's not in the default admin or at least in grappelli.

benjaoming commented 9 years ago

Yeah, normally having python3 support only happens on purpose :) Thanks :)

Neither do I understand why it's absent in even Grappelli and django-suit.. but let's keep this project alive as long as needed.