benjholla / CookieMonster

A utility for exfiltrating cookies from local browser cookie stores
MIT License
53 stars 30 forks source link

Build failures due to renamed "fat" target and List.of() unavailable in Java 8 #12

Closed samlindsaylevine closed 1 year ago

samlindsaylevine commented 1 year ago

Steps Taken

As per the readme, run mvn clean install -U (using the Maven version 3.8.1 that is bundled with IntelliJ).

Expected

The build will run and a fat JAR will be created in the /CookieMonster/target directory.

Actual

The build fails; the first failure is a Maven error

Descriptor with ID 'fat' not found

In addition, there is a compile problem because the pom.xml specifies 1.8 as the source and target version, but ChromeBrowser.java uses the factory method List.of() that was added only in Java 9.

Discussion

It appears that the maven-assembly-plugin changed its target from fat to jar-with-dependencies. The compile problem is remediable by changing the version.

I will soon open a PR to address this issue.