search

benji-york / manuel

Manuel lets you mix and match traditional doctests with custom test syntax.
Apache License 2.0
18 stars 15 forks source link

Python 3 and PyPy fixes and some other minor cleanups #1

Closed mgedmin closed 10 years ago

mgedmin commented 11 years ago

Ping?

benji-york commented 11 years ago

On Thu, Apr 11, 2013 at 5:26 AM, Marius Gedminas notifications@github.com wrote:

Ping?

I'm still alive. I will try my best to look at your branch in the next

48 hours.

Benji York

benji-york commented 11 years ago

I spent some time looking over the changes and I generally like what I see. I'm a little concerned about this output:

RefactoringTool: Refactored build/src/tests/api_tests.txt --- build/src/tests/api_tests.txt (original) +++ build/src/tests/api_tests.txt (refactored) @@ -39,7 +39,7 @@

dist.py_version == sys.version[:3] True

  • print dist.platform

  • print(dist.platform) None

[snip several similar transformations] RefactoringTool: Files that were modified: RefactoringTool: build/src/tests/api_tests.txt

I can't find how how this is being invoked, or what it is even (I assume it is the 2to3 tool). I would rather make the code and tests work under both python 2 and 3 than have install-time transformations happening. Can you provide any insight on what is triggering this?

mgedmin commented 11 years ago

Where do you see this output?

There's no file named api_tests.txt in the Manuel source tree. I suspect it might be Distribute itself (it uses 2to3, sadly, and it has a file called api_tests.txt that looks similar to this diff).

mgedmin commented 11 years ago

I've rebased my changes on top of the current master.

Some clarification: nothing in manuel itself relies on 2to3. tox creates virtualenvs for each Python version (under .tox); virtualenv installs distribute when run under Python 3.x, distribute uses 2to3. To my knowledge that's the only place where 2to3 gets involved while testing manuel.

(I expect soon we'll have virtualenv using setuptools 0.7, which AFAIK supports Python 3 natively, without using 2to3.)

cjw296 commented 10 years ago

merged in 94303b4fff53b533