search

benji-york / manuel

Manuel lets you mix and match traditional doctests with custom test syntax.
Apache License 2.0
18 stars 15 forks source link

Python 3.7 support #12

Closed jamesjer closed 5 years ago

jamesjer commented 6 years ago

The Fedora Linux distribution has started building packages with a prerelease of python 3.7, to catch problems early. The manuel package build fails like this:

====================================================================== FAIL: /builddir/build/BUILD/python-manuel-1.9.0/python3-manuel-1.9.0/src/manuel/README.txt:Parsing /builddir/build/BUILD/python-manuel-1.9.0/python3-manuel-1.9.0/src/manuel/README.txt:Parsing

Traceback (most recent call last): File "/builddir/build/BUILD/python-manuel-1.9.0/python3-manuel-1.9.0/src/manuel/testing.py", line 48, in runTest '\n' + DIVIDER + DIVIDER.join(results)) AssertionError:

File "/builddir/build/BUILD/python-manuel-1.9.0/python3-manuel-1.9.0/src/manuel/README.txt", line 83, in README.txt Failed example: region.start_match Expected:

<_sre.SRE_Match object...> Got: ---------------------------------------------------------------------- File "/builddir/build/BUILD/python-manuel-1.9.0/python3-manuel-1.9.0/src/manuel/README.txt", line 85, in README.txt Failed example: region.end_match Expected: <_sre.SRE_Match object...> Got:
jvalleroy commented 6 years ago

This issue is fixed in https://github.com/benji-york/manuel/pull/13. One remaining task, is to add python 3.6 and 3.7 to CI tests.

icemac commented 5 years ago

This ticket can be closed @strichter fixed it in 22a109c65ba722723f638de4fae526f40642d760.