benjiBase / pe

0 stars 0 forks source link

Lack of Support for Names from various cultures #5

Open benjiBase opened 2 weeks ago

benjiBase commented 2 weeks ago

not state within the planned enchancements

Description: When a European patient is being registered, they might have special names that is part of their culture but Sergio Pérez or Chloé or Kumagaru S/O how do the users add the patient in? Since healthcare, they might meet all sorts of people with different naming from different religion. should allow them enter such names as the patient.

Steps to Reproduce:

  1. Launch application.
  2. Attempt to add a patient with a name that contains accents or diacritical marks.- Example command add n/Sergio Pérez p/98765432 e/sergio@example.com i/V1234567S a/123 Example Street t/1

image.png

Expected Result: The system should accept names with accents and diacritical marks (e.g., é, ü, ç, /), as these letters.

Actual Result: Deny adding such patients

Proposed Solution: Include such addition of personal

soc-se-bot commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name input doesn't support cultural specific names

Description:
Cultural specific symbols such a s/o for Indian names are being rejected by the application. This is regrettable considering how this application is meant for doctors in Singapore and many patients might have this format in their naming.

Steps to Reproduce: Run the following sample command to add someone of name Kumar s/o Suresh

add n/Kumar s/o Suresh p/98765432 e/kumar@example.com i/T1234123A a/John Street, Block 123, #01-01 t/3

Expected Result:
It should successfully add the entry to the result, given that there is no one else with same NRIC.

Actual Result:
The following error message is received:

Names should only contain alphanumeric characters and spaces, and it should not be blank

Suggestion:

  • Perhaps add the support for s/o and other related symbols to be permitted in the name list.

[original: nus-cs2103-AY2425S1/pe-interim#3034] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: # catcher bug issue, if its accepted as a featureflaw than ignore the message below

it is a duplicate status but i cant see the reasoning or whether the team accepted/rejected the original issue. I would assume its rejected or not inscope as it came up as a pending case to be settled.

image.png

image.png

TLDR: I cant see on catcher if its accepted or rejected as its marked as duplication. I am assuming it might be rejected. hence putting as a disagree. In the case my issue is being that it make sense for people from different races to have different name formats and as a healthcare application it should allow us to register such users.