Subscription error handling

[gitrojones]

Hello,

Here's a fork with reproduction of the subscription issue I was running into involving error handling.

Setup:

1. Setup .env, replacing DATABASE_URL with your own
2. Run the server via yarn serve (Assumes Node20)

Steps:

1. Create a subscription in Ruru for Foo

   foo(fooId: $fooId) {
   event
   }
   }
   --- VARIABLES
   {
   "fooId": 1
   }

Expectations: The error that is thrown in the subscribePlan should be routed to the maskError where the error can be handled/sanitized like in queries and mutations.

Reality: The error is mishandled and throws an internal error instead. The handler is assuming originalError exists in grafast/prepare.js > output.

Why is this a bug? An internal error is unhandled leading to the socket error.

Thanks!

[benjie]

Reproduced with

    makeExtendSchemaPlugin({
      typeDefs: gql`
        extend type Subscription {
          error: Int
        }
      `,
      plans: {
        Subscription: {
          error: {
            subscribePlan() {
              return lambda(constant(3), () => {
                throw new Error("Testing error");
              });
            },
          },
        },
      },
    }),

[benjie]

Closing in favour of https://github.com/graphile/crystal/issues/2080