search

benjipott / video.js-chromecast

Use chromecast with videojs html5 player
Other
207 stars 86 forks source link

Video.js 6.x compatibility #32

Closed iencotech closed 7 years ago

iencotech commented 7 years ago

Hi, I think this plugin is awesome, and it would be great to make it compatible with Video.js 6.x versions.

When loading the plugin with Video.js 6.2.0 I get this error:

video.min.js:2 Uncaught Error: Illegal component, "Chromecast"; techs must be registered using Tech.registerTech(). at Function.t.registerComponent (video.min.js:2) at Object.<anonymous> (videojs-chromecast.js:881) at Object.2 (videojs-chromecast.js:885) at s (videojs-chromecast.js:7) at videojs-chromecast.js:7 at Object.<anonymous> (videojs-chromecast.js:916) at Object.3../component/control-bar/chromecast-button (videojs-chromecast.js:967) at s (videojs-chromecast.js:7) at videojs-chromecast.js:7 at Object.<anonymous> (videojs-chromecast.js:982)

Is it possible to make it compatible with 6.x version? Thanks very much.

iencotech commented 7 years ago

I added this related pull request https://github.com/benjipott/video.js-chromecast/pull/33

iencotech commented 7 years ago

Fixed with the merged pull request.