benjipott / video.js-chromecast

Use chromecast with videojs html5 player
Other
207 stars 86 forks source link

Crash on chrome based browsers #35

Open iencotech opened 7 years ago

iencotech commented 7 years ago

Hi,

I am facing a problem using Samsung Internet browser. Since it is a chrome based browser, VideoJS detects it as Chrome and the plugin tries to load the casting functionality, however I get a JS error saying that "chrome is not defined", breaking javascript execution and not being able to use VideoJS at all.

In order to fix this problem, the code could be added a check to not continue if the global variable chrome is not defined.

The intention of this fix would not be to make casting work for these browsers, rather would be about fixing the plugin to not crash on these type of browsers when using the plugin.

Thanks very much!

ghost commented 6 years ago

Fixed with #41