search

benjipott / video.js-chromecast

Use chromecast with videojs html5 player
Other
207 stars 86 forks source link

Fix the metadata and appId options assignments #37

Open alexgerv opened 7 years ago

alexgerv commented 7 years ago

Currently, the appId is not being set correctly and was always defaulting to the default ID because the option was undefined. The metadata was also affected by the same issue, and was fixed by PR #30

The proposed fix is to populate the options before calling super. Let me know what you think.

drexseoj commented 7 years ago

We like to vote for this issue. as we can not use our own receiver unless we modify the module.

alexgerv commented 7 years ago

@benjipott any comment on the PR ? Would you have another approach ?

Fenny commented 6 years ago

@benjipott hello?

DoomTay commented 6 years ago

Curiously, when I tried running this on a local HTML file or from a local server or even CodePen, the Chromecast button wouldn't show up, though it works just fine when running off a userscript.

Looking at it further, it seems the cause is that something about populating the options before calling super causes the receiverListener to fire only once.