benjipott / video.js-chromecast

Use chromecast with videojs html5 player
Other
207 stars 86 forks source link

Video.js 7.x compatibility #70

Open JordanChazottes opened 6 years ago

JordanChazottes commented 6 years ago

Hi, it would be great to make this plugin compatible with Video.js 7.x versions.

When loading the plugin with Video.js 7.0.3 I get this error:

video.js:4554: Illegal component, "Chromecast"; techs must be registered using Tech.registerTech(). at Function.registerComponent (video.js:4554) at Object. (videojs-chromecast.min.js:7) at Object.2 (videojs-chromecast.min.js:7) at n (videojs-chromecast.min.js:7) at videojs-chromecast.min.js:7 at Object. (videojs-chromecast.min.js:7) at Object.3../component/control-bar/chromecast-button (videojs-chromecast.min.js:7) at n (videojs-chromecast.min.js:7) at videojs-chromecast.min.js:7 at Object. (videojs-chromecast.min.js:7)

Is this upgrade possible ? Thanks

saPhil commented 6 years ago

I would love to know if there's a plan to upgrade this as well.

ThomasWoodard commented 6 years ago

I could really use this also.

nasy commented 6 years ago

Any news on this? :)

Fenny commented 6 years ago

I'm not experienced with videojs plugins, but for my website I use an external player using my own wrapper: https://github.com/Fenny/ChromecastJS

Maybe this is useful for people who want to create a 7.x plugin

sgotre commented 5 years ago

anybody checked out this one? https://github.com/StreamOneNL/video.js-chromecast/commit/e3fc563f3bbfab07452543f2c464438890494be9

karlbernard2 commented 4 years ago

Anyone found a solution for videojs 7?

I tried this:

https://github.com/leochen1216/video.js-chromecast

But can't see the plugin after loading the JS.

sgotre commented 4 years ago

@karlbernard2 what did you try to change?

karlbernard2 commented 4 years ago

@karlbernard2 what did you try to change?

I finally got it working by changing from https://github.com/leochen1216/video.js-chromecast:

import videojs from 'video.js/dist/alt/video.core';

to:

import videojs from 'video.js';