search

benjojo / alertmanager-discord

Take your alertmanager alerts, into discord
Apache License 2.0
177 stars 78 forks source link

Removed GOARCH parameter to be able to build arm images #16

Closed visibilityspots closed 3 years ago

visibilityspots commented 3 years ago

Hi,

I have a nomad based cluster with a lot of arm devices. To be able to run your image on those I removed the GOARCH parameter from the Dockerfile and builded the images using buildx;

$ docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
$ docker buildx build -t benjojo/alertmanager-discord:latest --platform linux/amd64,linux/arm/v6,linux/arm/v7 --push .

by building this way you still have one tag available latest but available with multiple architectures as you can see on my docker hub. As soon as you have those architectures available I'll remove those images!

You could perhaps consider to create a github workflow like I did for a cloudflared image. That way the image is rebuild every week with a potential new alpine base container..

benjojo commented 3 years ago

LGTM, Thanks

benjojo commented 3 years ago

For what it is worth, the docker hub stuff auto builds the image, I'm honestly not that "hot" on dockerhub magic, someone else helped me getting all of that working. Thanks for the PR anyway!

visibilityspots commented 3 years ago

I do get that, but unfortunately the docker hub auto build only builds for amd64 and not arm :( so the PR without a mechanism to build both architecture doesn't solve the issue I encounter :(