benjp009 / awesome-books

Creating a book library with Charles

2 stars 0 forks source link

Morning Session: Peer to Peer Code Review #7

Open AnselemOdims opened 2 years ago

AnselemOdims commented 2 years ago

Commendations

Good functionality implementation

Suggestions

I would suggest using colors to make it interactive
It would be a good user experience if the input fields are cleared on submit
It would be nice if the footer is not fixed or sticky

AmaduKamara commented 2 years ago

Morning Session Code Review

You guys have done great work.

Your design looks closely alike to the low-fidelity wireframe given ✔️
All functionality is working as required ✔️

Recommended changes: ♻️

So far there are a few recommendations I would suggest you consider implementing in order to make your program better:

It will be great the footer matches the header for design consistency
I suggest you don't set the footer to be sticky. Make the sections to have full height and subtract the header's and footer's height from the view height. You can use - height: calc(100vh - 100px) function.