search

benjypng / firefox-extension-logseq-quickcapture

firefox-extension-logseq-quickcapture
MIT License
37 stars 4 forks source link

Unable to capture on Firefox 110+ after latest extension update #8

Closed dklawren closed 1 year ago

dklawren commented 1 year ago

When using the latest version of the extension which was recently updated to work with Firefox 110+, I am not able to properly capture anything to Logseq. When clicking the button on a page which I want to capture, the extension opens a new tab where I see a conformation dialog to open asking if it is OK to open the link using Logseq. Before I can do anything, the dialog disappears and the tab closes itself. Sometimes, not always, I can click the open link button fast enough and I will get the capture properly created in Logseq. But it takes multiple tries.Would it be possible to do away with the timeout and close the tab only after the dialog has been confirmed?

OS: Linux Firefox: Nightly 112.0a1

benjypng commented 1 year ago

I have made the rectification. But I am unable to upload it to the firefox developer console. If you need to, you can download it directly from Github?

On Tue, Feb 21, 2023 at 11:56 PM David Lawrence @.***> wrote:

When using the latest version of the extension which was recently updated to work with Firefox 110+, I am not able to properly capture anything to Logseq. When clicking the button on a page which I want to capture, the extension opens a new tab where I see a conformation dialog to open asking if it is OK to open the link using Logseq. Before I can do anything, the dialog disappears and the tab closes itself. Sometimes, not always, I can click the open link button fast enough and I will get the capture properly created in Logseq. But it takes multiple tries.Would it be possible to do away with the timeout and close the tab only after the dialog has been confirmed?

OS: Linux Firefox: Nightly 112.0a1

— Reply to this email directly, view it on GitHub https://github.com/hkgnp/firefox-extension-logseq-quickcapture/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNXKGJ43ATEFKJNINTHBFTWYTQS3ANCNFSM6AAAAAAVDHC76Y . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dklawren commented 1 year ago

I have made the rectification. But I am unable to upload it to the firefox developer console. If you need to, you can download it directly from Github?

I am using the previous iteration of this fix for a bit and is working fine. I was not able to use the xpi in the github repo as it would generate errors when I try to push the button. And also the icon would not display. Not sure what I am doing wrong.

Were you able to figure out why you cannot upload the new version to the Addons console? I would rather download the new version directly from there if possible.

benjypng commented 1 year ago

Fixed.