search

benjypng / logseq-datenlp-plugin

MIT License
74 stars 6 forks source link

Adding date on task completion is incorrect with scheduled/deadline/logbook #15

Closed scottcs closed 2 years ago

scottcs commented 2 years ago

I absolutely love the new functionality of task completion with adding a date reference to the task. There is one thing that is not quite working with it, however.

If I have a task that is already scheduled (using /schedule), or has a deadline, or has been in the DOING state for a while and has a logbook associated with it, and I use cmd-shift-d to complete the task and add a link to today's date, it adds the link at the end of the entire block rather than at the end of the task description. Logseq does not seem to recognize this task on the journal page, unfortunately.

Example:

Screen Shot 2022-03-26 at 5 23 58 PM

Observed behavior:

Screen Shot 2022-03-26 at 5 24 07 PM

Desired behavior:

Screen Shot 2022-03-26 at 5 27 34 PM
benjypng commented 2 years ago

Fixed in v3.9.9. Pls try and see how it goes.

scottcs commented 2 years ago

Working much better for scheduled and deadline TODO state, thank you!

I did notice another problem, though. When a task is already in the DOING state and I use cmd-shift-d, it does not mark the task as DONE and also puts the date after the LOGBOOK entry.

benjypng commented 2 years ago

Could you try with 3.9.11 please? Thanks.

scottcs commented 2 years ago

Yes, it is all working now!

The only weird thing is if a task has no scheduled and no deadline, is in the DOING state, then hit cmd-shift-d, the date reference is added on a new line instead of at the end of the task description. But Logseq still sees it and shows it in linked references on the journal page, so I would say it is working.

Thanks again so much!