Additional languages?

[georgd]

How are the languages implemented? Is it very difficult to add more? I’d like to use it in German.

If it’s necessary for adding the language to do some translation work, I’m ready to help.

[benjypng]

You can try following the instructions here, and put "de". E.g. in your logseq-datenlp-plugin.json file:

{
    "lang": "de"
}

[georgd]

Sorry, that doesn't work. Perhaps the code in parseDates.tsx prevents it?

 ​    ​if​ ​(​lang​ ​===​ ​'fr'​ ​||​ ​lang​ ​===​ ​'ja'​ ​||​ ​lang​ ​===​ ​'nl'​ ​||​ ​lang​ ​===​ ​'en'​)​ ​{

[benjypng]

Ah, apologies forgot to add in the partially supported languages.

Please update to v3.8.4 and try again.

[georgd]

Great, thanks! It works now. Could you please tell me in how far these languages are only partially supported?

[benjypng]

I have actually no idea! I don't speak German so I can't test. Perhaps maybe some linguistic styles within the German language are not supported? I'm not sure.

On Tue, Feb 15, 2022 at 4:35 PM Georg Mayr-Duffner @.***> wrote:

Great, thanks! It works now. Could you please tell me in how far these languages are only partially supported?

— Reply to this email directly, view it on GitHub https://github.com/hkgnp/logseq-datenlp-plugin/issues/9#issuecomment-1039999403, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNXKGI7GDH6ZBDS2RFUWGLU3IF57ANCNFSM5OMVXZOQ . You are receiving this because you commented.Message ID: @.***>

[georgd]

OK, found out it’s chrone-node where DE is missing some parts that are present in the fully supported ones. But the basic parsing is fine.

[benjypng]

I see! Feel free to do PRs for chrono-node and it's merged, I'll update the dependency version on the plugin as well.

[natrius]

Is it possible to use english and german at the same time?