benjypng / logseq-filterpage-plugin

Filter the current page based on tags that you want to include or exclude.
MIT License
3 stars 0 forks source link

The plugin is not working #2

Open jayguangyuan opened 2 months ago

jayguangyuan commented 2 months ago

logseq version 0.10.8, the page does not change after clicking the tag.

benjypng commented 2 months ago

I am going to need more information though. Can you paste a sample of your page here for me to test?

jayguangyuan commented 2 months ago

2024_02_19.md

I uploaded a file. I think this is of little use. It has no effect when I use it on any interface. I downloaded version 0.10.9, but it still has no effect. The system I am using is win10.

eisenbahnman commented 1 month ago

The plugin works partially and sometimes breaks down. In my case, it does not filter correctly, and a simple recreation of the demonstration example results in the plugin becoming unresponsive. I'd really love for this plugin to work, it's one of the main features I miss from Roam.

CleanShot 2024-10-01 at 13 06 12

benjypng commented 1 month ago

2024_02_19.md

I uploaded a file. I think this is of little use. It has no effect when I use it on any interface. I downloaded version 0.10.9, but it still has no effect. The system I am using is win10.

Hmm based on your example, the document itself does not seem to contain any tags. Only page properties. Just to make sure, a tag is something like #[[groceries]] or #happiness.

benjypng commented 1 month ago

The plugin works partially and sometimes breaks down. In my case, it does not filter correctly, and a simple recreation of the demonstration example results in the plugin becoming unresponsive. I'd really love for this plugin to work, it's one of the main features I miss from Roam.

CleanShot 2024-10-01 at 13 06 12 CleanShot 2024-10-01 at 13 06 12

I cannot seem to reproduce the TODO example.

Regarding the Note to Self issue, it is as per design at the moment, as I think sibling blocks seem to be important in a filter. But perhaps it isn't 🤔. Happy to review this though.

eisenbahnman commented 1 month ago

Regarding TODO issue: it seems to become unresponsive when the filter engages, but doesn't actually filter out anything, for example:

In this instance, I believe setting the filter on TODO would return both Child and TODO child, because it leaves siblings intact. It becomes unresponsive.

But if you have something like this:

The last bullet will be filtered out, and filter will work normally. This is also true when filtering for #hashtags or [[references]].

Easiest way to recreate is to create just a single bullet with TODO and try to filter it out.

As for the design of leaving sibling blocks intact, I can see use cases where seeing context would be useful, but it makes longer outlines completely unreadable when filtering. First and foremost, I would expect the filter to leave only blocks that directly correspond to filtered references. Could be an additional setting to leave siblings intact.