benjypng / logseq-readwise-plugin

MIT License
66 stars 9 forks source link

Twitter threads are ordered in the wrong order inside highlights #7

Closed silver-vlas closed 2 years ago

silver-vlas commented 2 years ago

When syncing a thread, In the readwise highlights section, the threads are synced in the reverse order, which means it's basically unreadable.

The linked reference that appears in the Journal daily page, has sorting which is even weirder, it does not seem to follow any kind of logical pattern of sorting.

Example in the linked image.

image

benjypng commented 2 years ago

Thanks for highlighting this!

Can I check if you are sorting the highlights by recent first or recent last?

On 29 Dec 2021, at 5:44 PM, silver-vlas @.***> wrote:

 When syncing a thread, In the readwise highlights section, the threads are synced in the reverse order, which means it's basically unreadable.

The linked reference that appears in the Journal daily page, has sorting which is even weirder, it does not seem to follow any kind of logical pattern of sorting.

Example in the linked image.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

silver-vlas commented 2 years ago

Where would this setting be? I have not changed anything from the default neither in Readwise nor in the plugin.

benjypng commented 2 years ago

Hmm, which version are you on currently?

On 29 Dec 2021, at 6:47 PM, silver-vlas @.***> wrote:

 Where would this setting be? I have not changed anything from the default neither in Readwise nor in the plugin.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

silver-vlas commented 2 years ago

Logseq Version: 0.5.5 Plugin Version: 3.01

benjypng commented 2 years ago

Hey! I deleted your comment as you included your API token!

I'll look into it and update you.

benjypng commented 2 years ago

Can you uncheck the checkbox "Sort recent highlights first"? Then the recent tweets will be at the bottom.

Screenshot 2021-12-29 at 7 55 02 PM

I also noticed that your "Readwise Highlights" header keeps getting recreated. Do you typically change it after you import a source, e.g. change from h2 to regular size? If you do so, the header "Readwise Highlights" will keep getting repeated.

silver-vlas commented 2 years ago

Yes, that works in the highlights page. Thank you. But the Linked Reference page in the Journal is still not properly sorted from what I see.

silver-vlas commented 2 years ago

For Example: image

benjypng commented 2 years ago

Hmm I am not sure how Linked References are sorted though. It's not controlled by the plugin as far as I know.

silver-vlas commented 2 years ago

I think perhaps that having the date as a property in every sub-block under "on" may be confusing logseq.

In roam, I had configured Readwise to add the date on the [[Readwise Highlights]] row as a header to the entire paragraph and thus the linked reference would be a single one for the entire thread.

benjypng commented 2 years ago

Thanks for the suggestion! Will see if I can add this feature request for a future update!