benjypng / logseq-todoist-plugin

MIT License
124 stars 20 forks source link

Feature proposal: Options to control where to attach the link between Todoist and Logseq #34

Closed TomazWang closed 2 years ago

TomazWang commented 2 years ago

I'm not a native English user. Please forgive my grammar errors. Thanks. πŸ™‡

Why

Currently, when appendLogseqUri is enabled, the whole block will be link to Todoist task. The same behavior happens when appendTodoistUrl is enabled. If there are any links in the block, it will be disabled(like image below).

image

What

This PR expands appendLogseqUri and appendTodoistUrl settings. Let users chose where to append the link in Logseq and Todosit.

There are three options for links from Logseq to Todoist(appendTodoistUrl): Disable, Link content and Append link. Disable and Link content act like the original disable and enable. Append link put additional (todoist) text at the end of original content and attach the Todoist link on it.

image

image

There are three options for links from Todoist to Logseq as well(appendLogseqUri): Disable, Link title and Link description. Disable and Link title behaviors the same as the old disable and enable. Link description puts Logseq block uri in task description.

image

image

Also, this PR implements the setting migration.

Note

Even though I think this function are good, I don't think those names of options are good enough to the final product.

benjypng commented 2 years ago

Thanks!