Todoist sendtask improve

benjypng / logseq-todoist-plugin

MIT License

124 stars 20 forks source link

Todoist sendtask improve #54

Closed howarddo2208 closed 1 year ago

howarddo2208 commented 1 year ago

index.tsx: Send task logic fix
- sendDefaultLabel with no settings are equal "" not "--- ---" -> never display Send Task form (fixed)
deadline/schedule + repeat parsing to Todoist

benjypng commented 1 year ago

Hi! Thanks for the PR.

(1) Unfortunately, I cannot reproduce the issue. Or perhaps I am not understanding you correctly. (2) It's a nice FR but currently I am not keen to accept a PR that makes changes to the core code. The last time I did that, it was very difficult to troubleshoot issues brought up by other users. Will take it upon as a FR though.

howarddo2208 commented 1 year ago

Ok, the first fix is to address the issue that would make the form never displayed even if no settings are set besides API key. For the second issue, it's ok, you take your time then.