benjypng / logseq-todoist-plugin

MIT License
125 stars 19 forks source link

Custom filters #62

Closed Fraternal0470 closed 1 year ago

Fraternal0470 commented 1 year ago

Hey,

I had a go implementing https://github.com/hkgnp/logseq-todoist-plugin/issues/56.

Appreciate the feedback.

andreoliwa commented 1 year ago

@Fraternal0470 this PR broke the task retrieval functionality: https://github.com/hkgnp/logseq-todoist-plugin/issues/68

  1. taskArgs on line 228 is not being set:

https://github.com/hkgnp/logseq-todoist-plugin/blob/02a380b49185112b85caf6f3b145dd95ae9802d5/src/services/todoistHelpers.ts#L209-L220

  1. The signature of retrieveTasks() didn't change; it still accepts a flag argument. But it's being called in 2 places with an object.

https://github.com/hkgnp/logseq-todoist-plugin/blob/02a380b49185112b85caf6f3b145dd95ae9802d5/src/index.tsx#L74

https://github.com/hkgnp/logseq-todoist-plugin/blob/02a380b49185112b85caf6f3b145dd95ae9802d5/src/index.tsx#L82

  1. 2 other places still use the old signature with flag as the 2nd parameter.

https://github.com/hkgnp/logseq-todoist-plugin/blob/02a380b49185112b85caf6f3b145dd95ae9802d5/src/index.tsx#L115-L120

I'm still looking at the code but I figured you would be able to fix it quicker than I do. I still don't understand what you did and what to change.

@hkgnp having a TS linter would help to avoid such issues in the future.

andreoliwa commented 1 year ago

I created a PR, you you can review: https://github.com/hkgnp/logseq-todoist-plugin/pull/69

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: