benjypng / logseq-todoist-plugin

MIT License
125 stars 19 forks source link

Fix the problem of Labels parameter when adding tasks #63

Closed DevTalking closed 1 year ago

DevTalking commented 1 year ago

The Todoist API for adding tasks, the labels parameter asks not for an ID but for a Name. The task's labels (a list of names that may represent either personal or shared labels).

So you should use the getNameFromString method.

benjypng commented 1 year ago

The Todoist API for adding tasks, the labels parameter asks not for an ID but for a Name. The task's labels (a list of names that may represent either personal or shared labels).

So you should use the getNameFromString method.

Thank you. Sorry for the delay. I don't use Logseq anymore so I haven't been paying attention.

PR merged.

andreoliwa commented 1 year ago

I don't use Logseq anymore so I haven't been paying attention.

Hello @hkgnp! 👋🏻 I have two questions. 🙂


First question: have you switched to another PKM tool? I'm always comparing tools, and I'm curious to know if there's anything better than Logseq.


Second question: If you don't have time or will to maintain this (great) plugin, did you consider...

  1. ...writing a disclaimer on the README "this project is not maintained due to XYZ"?
  2. ...adding other contributors to this repo?
  3. ...asking for maintainers and transferring ownership of the repo?

I saw this PR from May with no feedback: https://github.com/hkgnp/logseq-todoist-plugin/pull/62 And I added a PR myself in June, also unanswered: https://github.com/hkgnp/logseq-todoist-plugin/pull/64.

I totally understand not having time to focus on open-source projects (I have this problem myself). But I believe it's polite to let contributors know that their code is not gonna be reviewed anytime soon. 😅

benjypng commented 1 year ago

Hi @andreoliwa thanks for the feedback. I've merged the PRs as well. I've also updated the README for this repository.

Tanchwa commented 1 year ago

This actually did not end up fixing the issue @hkgnp , the tags still show up as the number IDs

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: