FR: both a custom hashtag and date format should be configurable

benwittorf commented 2 years ago

I love your plugin. This really looks like it could eventually make use Twitter!

Having said that, for the Logseq part, I have two small suggestions: allow a custom hashtag and a custom date format.

As for the date format, I think it's common to use "preferredDateFormat": "your date format" (like "YYYY-MM-dd" in the plugin settings—I don't know if the global setting can be retrieved),
and for the custom hashtag, I'd suggest a setting like "hashtagTweeted": "#yourcustomhashtag"

Thanks for your consideration—and again, for the plugin!

benjypng commented 2 years ago

1) Custom hashtag This is part of the roadmap!

2) Custom date format Currently it follows the user's preferred date format that is defined by the user in Logseq. If your Logseq's custom date format is not being followed, please open another issue. Thanks!

benwittorf commented 2 years ago

Done.

As an addendum to 1., it would probably make sense to have the whole string edible, which probably would solve any multilingual issues that may come up otherwise.

benjypng commented 2 years ago

(1) is on v1.7 in the marketplace (https://github.com/hkgnp/logseq-tweet-plugin#setting-custom-hashtags-for-successful-tweets)

benjypng / logseq-tweet-plugin

FR: both a custom hashtag and date format should be configurable #4