benkasminbullock / Lingua-EN-PluralToSingular

change an English plural to a singular
https://metacpan.org/release/Lingua-EN-PluralToSingular
3 stars 4 forks source link

What to do with proper nouns that are plural? #14

Closed XanC closed 10 years ago

XanC commented 10 years ago

This may be out of scope.

A user might want, for example, "gonzaleses" to singularize to "gonzales". Instead it goes to "gonzalese". I think this would happen to many, many names, and I'm not sure what could possibly be done about it.

benkasminbullock commented 10 years ago

Which is more common, eses -> es or eses -> ese?

XanC commented 10 years ago

I would think it would be eses -> es. "Joneses" -> "Jones" alone is probably a good chunk of them, and I believe all the Hispanic-origin names like Gonzales, Rodrigues, etc, will behave that way too.

benkasminbullock commented 10 years ago

This is the way it is in version 0.12 already:

$ singular Joneses
Jones 

I can add a test for it but it seems to be OK right now.

benkasminbullock commented 10 years ago

I'm closing this due to no response I assume this is resolved. Please feel free to reopen it.