benkeen / generatedata

A powerful, feature-rich, random test data generator.
https://generatedata.com
2.22k stars 611 forks source link

Country to allow short/full just as region #206

Open ptahchiev opened 10 years ago

ptahchiev commented 10 years ago

Hi there,

when I select country as dataType it only offers me "Limit countries to those selected above", but when I select region it also offers me "full/short" option. I want to have that for country too, so I can generate for instance:

uk, United Kingdom bg, Bulgaria de, Germany ...

benkeen commented 10 years ago

Good call... let me think on this a bit. Seems like a good addition.

benkeen commented 10 years ago

I like this, but I'm bumping it from 3.1.4. I think the $countrySlug var could be refactored to be $countryShortCode & use the ISO 2-char standard for each country. The Country Data Type could then be updated to use it - just a question of regression, really.