search

benkeen / generatedata

A powerful, feature-rich, random test data generator.
https://generatedata.com
2.21k stars 610 forks source link

Column Names should be encapsulated #759

Closed MarcusCulverTHL closed 1 year ago

MarcusCulverTHL commented 2 years ago

I recently pulled a data set where I named the columns "phone-uk"

Because for SQL Server these weren't encapsulated in square parentheses the import of the data set failed due to hyphens being a reserved character.

Column names (if abiding by best practise) should be qualified by square parentheses ( [phone-jp] ) to ensure the engine doesn't consider the hyphen as something else

benkeen commented 2 years ago

Thanks! Will add this in the next release.

benkeen commented 1 year ago

Sorry, I've been pulled into other things the last couple of months. Finally returning to this now, so expect an update in the next few weeks.

benkeen commented 1 year ago

I took a look at this and found a couple of related issues (the error message shouldn't have appeared when you used a hyphen and it had the wrong message), but encapsulating the column names seems to be working properly - see screenshot.

Screen Shot 2022-11-26 at 3 32 03 PM

I haven't released the new version yet (should be hopefully later today). But if you still see a problem, just chime in here and I can re-open.