benkeen / generatedata

A powerful, feature-rich, random test data generator.
https://generatedata.com
2.2k stars 611 forks source link

Adds Mexican female names, male names and last names #848

Closed itaquito closed 8 months ago

itaquito commented 8 months ago

Hey!

I added some Mexican names and last names as #710 asked. The source I used is the INEGI, which is the organization of demographic data of Mexico.

Hope it helps! Thanks.

benkeen commented 8 months ago

Great stuff, thanks @itaquito! One question: I see for a lot of the first names, there are 2 names like Maria Jose or Evelyn Guadalupe. Would the second be considered a middle name or part of the first name? The reason I ask is that the Names field has a bunch of placeholders like MaleName and FemaleName so I wanted to confirm that it would be appropriate for both names to appear if the user entered one of those placeholders.

itaquito commented 8 months ago

That's a really interesting question. Technically, it's considered as a middle name, however, you can also consider it as a whole first name since we only use certain combinations of first names and middle names.

For instance, it's common for a female name to use Maria and a male name to use José as the first name and then another name as the middle name. Other combinations that may be generated randomly like Valentina Regina are not really a common thing.

I think it's appropriate for both names to appear as just one name. However, I do understand that it may be unexpected to users that the placeholders MaleName and FemaleName generate two words. Tell me what you decide! If you want, I can edit the list and just leave the one-word names.

benkeen commented 8 months ago

Yeah, interesting one! I think it should probably be considered correct though. Let's add it in as-is and see if anyone complains about it. Thanks again! I'll release a new version this weekend to include your change. :)