FIX - ListUsers and ListGroups operation, Filter is deprecated

benkehoe / aws-sso-util

Smooth out the rough edges of AWS SSO (temporarily, until AWS makes it better).

Apache License 2.0

932 stars 70 forks source link

FIX - ListUsers and ListGroups operation, Filter is deprecated #108

Closed zhujian0805 closed 10 months ago

zhujian0805 commented 10 months ago

Currently, the GitHub repo serves as the documentation for aws-sso-util and aws-sso-lib, which means master needs to stay close to the published version of the code. For this reason, please open your pull requests against the next branch. The next branch gets merged to master when creating a release. Ideally the documentation should live on, say, readthedocs.org, but I have not gotten to that yet.

benkehoe commented 10 months ago

Two things:

As explained in the pull request instructions that you left in place verbatim, pull requests must be again the next branch.
The purpose of these commands is to translate group/user name into group/user id. Deprecation of the Filters is not intended to make users manually filter the entire list; the functionality is provided directly through GetGroupId and GetUserId, which should be used instead.

zhujian0805 commented 10 months ago

thanks for review, I will update the code using the GetGroupId and raise a new PR :)

I also want to show the user-group anf group-user mapping, not sure if this can achieved by existing functionality.

zhujian0805 commented 10 months ago

since the aws identitystore can do most of the things, i am just closing this PR