benklop / microblog-purple

Automatically exported from code.google.com/p/microblog-purple
GNU General Public License v3.0
0 stars 0 forks source link

twitgin links do not work under 2.6.1 #141

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.  enable twitgen plugin
2.  await receipt of a "tweeted" message
3. attempt to reply, retweet, or mark as favorite

What is the expected output? What do you see instead?
Expected response is to see the appropriate text in the 'sending' portion
of the chatbox.

Instead, no output is seen. only the timeline link or username links which
call the outboard browser works.

What version of the product are you using? On what operating system?
pidgin 2.6.1,  mb-purple svn312

Please provide any additional information below.
No errors or other messages appear while running under debug.

Original issue reported on code.google.com by ak.hep...@gmail.com on 19 Aug 2009 at 10:39

GoogleCodeExporter commented 9 years ago
Hovering over the various links shows that they are properly generated. They 
are just
not inserted correctly into the text stream

Original comment by ak.hep...@gmail.com on 19 Aug 2009 at 11:11

GoogleCodeExporter commented 9 years ago
this is reproducible on both Windows(XP) and Linux.

Original comment by ak.hep...@gmail.com on 20 Aug 2009 at 1:10

GoogleCodeExporter commented 9 years ago
Ok, I found the cause. Pidgin 2.6 change the way to handle url. Now we must call
gtk_imhtml_class_register_protocol to handle our protocol.

Code will need to be changed that will make it not compatible with 2.5.x. 

Original comment by somsaks on 20 Aug 2009 at 5:46

GoogleCodeExporter commented 9 years ago
Hrm.. it seems like you could use purple_version_check to decide which method 
to use,
in which case you'd remain backwards compatible...

Original comment by ak.hep...@gmail.com on 20 Aug 2009 at 6:08

GoogleCodeExporter commented 9 years ago
Yep i plan to do just that. #if + PURPLE_VERSION_CHECK or something similar.

It will take sometime though. It's not just a simple bug. 

Original comment by somsaks on 20 Aug 2009 at 6:26

GoogleCodeExporter commented 9 years ago

Original comment by somsaks on 26 Aug 2009 at 6:33

GoogleCodeExporter commented 9 years ago
Ok, latest SVN (r316) temporary fix this issue. The more proper fix might be 
appear
in next major release instead.

Original comment by somsaks on 26 Aug 2009 at 5:33

GoogleCodeExporter commented 9 years ago
Hrm..  may have to purge  pidgin completely  and reinstall??

twitgin.c:443: error: expected declaration specifiers or ‘...’ before 
‘GtkIMHtmlLink’
twitgin.c: In function ‘twitgin_url_clicked_cb’:
twitgin.c:445: warning: implicit declaration of function 
‘gtk_imhtml_link_get_url’
twitgin.c:445: warning: initialization makes pointer from integer without a cast
twitgin.c: At top level:
twitgin.c:455: error: expected declaration specifiers or ‘...’ before 
‘GtkIMHtmlLink’
make[1]: *** [twitgin.o] Error 1
make[1]: Leaving directory 
`/usr/local/src/pidgin/microblog-purple-read-only/twitgin'
make: *** [build] Error 1

Original comment by ak.hep...@gmail.com on 26 Aug 2009 at 6:06

GoogleCodeExporter commented 9 years ago
Apparently it was my weird layout -- i'd done an overlay install of 2.5.8 onto a
previously installed 2.6.1, but some things didn't get cleaned out, so it looks 
like
it was trying to link mixed versions.

Full purge/re-install gives a clean build with 2.6.1 and svn216.   All twitgin 
links
are working.

Original comment by ak.hep...@gmail.com on 26 Aug 2009 at 6:52

GoogleCodeExporter commented 9 years ago

Original comment by somsaks on 27 Aug 2009 at 4:27

GoogleCodeExporter commented 9 years ago
Issue 145 has been merged into this issue.

Original comment by somsaks on 29 Aug 2009 at 3:17

GoogleCodeExporter commented 9 years ago
Issue 146 has been merged into this issue.

Original comment by somsaks on 7 Sep 2009 at 10:19