search

benknoble / vim-racket

vim bundle for Racket
MIT License
25 stars 4 forks source link

Prepare files for distribution with Vim #8

Closed dkearns closed 2 years ago

dkearns commented 2 years ago
dkearns commented 2 years ago

Sorry I've been a bit sidetracked but I'll come back to it next week.

I think using :highlight and losing the alignment will be fine. In my experience, Bram is usually pretty relaxed about this sort of thing. I think he is man who believes in filling the pan with larger fish.

You'll be joining an illustrious list of about half a dozen other rebel syntax file authors. :smile:

benknoble commented 2 years ago

Thanks for the updates. I plan to build a vimscript indentexpr for Racket, but it's a hefty undertaking and I don't currently have time allotted for it 😢

dkearns commented 2 years ago

I think you could include the Racket syntax, ftplugin, and indent files as they are now and get away with using the current filename based filetype detection. It's definitely an improvement over defaulting to Scheme.

dkearns commented 2 years ago

Oh, there's also a " Last Change: 2022 Aug 12 line included for each file at the end of the header block.

dkearns commented 2 years ago

Thanks for the updates. I plan to build a vimscript indentexpr for Racket, but it's a hefty undertaking and I don't currently have time allotted for it cry

Supporting formatprg wouldn't be a bad start.

benknoble commented 2 years ago

Oh, there's also a " Last Change: 2022 Aug 12 line included for each file at the end of the header block.

Do I write this myself or does Bram update it when including them? Asking because it's not in the PR but should be trivial for me to add after merging.

benknoble commented 2 years ago

Supporting formatprg wouldn't be a bad start.

I'm looking at #4 for that. Certainly a faster path to a solution.

dkearns commented 2 years ago

Oh, there's also a " Last Change: 2022 Aug 12 line included for each file at the end of the header block.

Do I write this myself or does Bram update it when including them? Asking because it's not in the PR but should be trivial for me to add after merging.

Yes, it's a bit of a pain to version control and it often only has any real meaning when included in the Vim distribution so most of us just add it when we update Bram.

benknoble commented 2 years ago

I've got just one or two things to clean up, and then I'll send to vim/vim. Is a PR adding those files the right way to go (for a non-mailing-list expert)?