search

benkonrath / transip-api

Python implementation for the TransIP API
https://transip-api.readthedocs.io/en/latest/
MIT License
23 stars 23 forks source link

Replace '+' with '%20' in signature parameters #15

Closed Forage closed 8 years ago

Forage commented 9 years ago

It is not uncommon to use spaces in DNS entry content. The current signing implementation will never produce a valid TransIP signature when this occurs. The use of PHP's rawurlencode() in the TransIP sources results in spaces being replaced by %20. Python's urllib.urlencode() will produce + characters instead.

The fix will create a valid signature. Existing + characters in a value should not cause a problem because they will already be replaced by urllib.urlencode().

benkonrath commented 8 years ago

This change is in #13 as well.

benkonrath commented 8 years ago

This has been merge via 816c8c1b54d85b94fc5c54a21795b9bd2ff1e636.