search

benkonrath / transip-api

Python implementation for the TransIP API
https://transip-api.readthedocs.io/en/latest/
MIT License
23 stars 23 forks source link

Add add_dns_entries function on DomainService. #48

Closed daramousk closed 5 years ago

roaldnefs commented 5 years ago

@benkonrath, what do you think of this addition? I thinks this is a good addition, I have already heard several people who are annoyed by the fact that you have to include all existing DNS entries. This function makes it more user-friendly but is not part of the TransIP API.

benkonrath commented 5 years ago

I think it's a good addition. :+1: I've had to write some code like this in an application but I think it makes sense to just have it in the library.

I could see a helper for remove and update also being useful - I haven't looked at the complexities, I'm just thinking as an application developer. To be clear: remove & update aren't required for this change to be merged.

roaldnefs commented 5 years ago

@daramousk thanks for your contribution!

If you want to take a stab at the suggestions of @benkonrath please let us know.

daramousk commented 5 years ago

Hey Roald and Ben, you are welcome, I will be pushing some extras as the requirements come in, I have already pushed another one.

Thanks for the quick response.