benkuper / Chataigne

Artist-friendly Modular Machine for Art and Technology
https://benjamin.kuperberg.fr/chataigne
GNU General Public License v3.0
1.22k stars 58 forks source link

When MTC input scrubs, sequence plays #167

Closed sebescudie closed 1 year ago

sebescudie commented 1 year ago

Environment

Describe the bug When a sequence is clocked by an external MTC source, scrubbing on this MTC source starts the sequence playback, even though the MTC source is paused.

To Reproduce Steps to reproduce the behavior:

  1. Create a MIDI module, set its input to a virtual MIDI device
  2. Open MTC Sender, set its MIDI Out parameter to the virtual MIDI device
  3. In Châtaigne, create a new Sequence, enable Sync Devices and set the input to the virtual MIDI device
  4. In MTC Sender, start the playback (Start button) : the sequence playback start
  5. In MTC Sender, stop the playback (Pause button) : the sequence playback stops
  6. In MTC Sender, move the Time Slider to "scrub" through time : Châtaigne will move the playhead and start the playback. MTC Sender is still paused

Expected behavior When scrubbing on an external MTC source and that source is paused, I would expect Châtaigne to just move the playhead without starting the playback

Additional context Been monitoring MIDI traffic with an external tool (Protokol). When scrubbing, MTC Sender sends a SysEx message. It looks like Châtaigne "interprets" this SysEx message as a play order. Tried a bunch of other things :

Let me know if I can provide additional details. Thanks!

benkuper commented 1 year ago

Can you try the latest bleeding edge ?

sebescudie commented 1 year ago

Working just fine now, thanks for the prompt fix. Closing!