search

benkuper / Chataigne

Artist-friendly Modular Machine for Art and Technology
https://benjamin.kuperberg.fr/chataigne
GNU General Public License v3.0
1.18k stars 56 forks source link

OSCQuery implementation doesn't respect HOST_INFO OSC_PORT #65

Closed alexdmiller closed 3 years ago

alexdmiller commented 4 years ago

Environment

Describe the bug I believe Chataigne is not using the OSC_PORT from OSCQuery's HOST_INFO object. See HOST_INFO in the protocol here.

To Reproduce Steps to reproduce the behavior:

  1. Add an OSCQuery module
  2. In the inspector, click "Auto detect" and select an OSCQuery server

Expected behavior The "Remote port" should be automatically set to the OSC_PORT found by navigating to 127.0.0.1:{oscquery_port}/?HOST_INFO. Instead, "Remote port" is set to the OSCQuery port. In the spec, it says this should be the default behavior if no OSC_PORT is provided, but that OSC_PORT should be respected if provided.

benkuper commented 4 years ago

Thank you for the feedback, I'll check that when I get some time

alexdmiller commented 4 years ago

I might have time today/tomorrow to take a look myself, but I'm not sure how long it will take to get the build up and running.

Do you think you will get to it in the next couple of days? If not, I'll take a crack at it!

benkuper commented 3 years ago

This is now working :)