US4 SearchBar & Styling - Githubissues

benkutdev / capstone

Capstone Project April 2023

https://vinyl-round-r3ku8bxxe-benkutdev.vercel.app/

0 stars 0 forks source link

US4 SearchBar & Styling #7

Open benkutdev opened 1 year ago

benkutdev commented 1 year ago

Value proposition

As a User I want to see a SearchBar in order to search albums

Description

Screenshot 2023-05-04 at 14 51 41

Acceptance criteria

display a proper SearchBar in the top right corner
Header colour changes from orange to green
App Logo changes from green to orange

Tasks

implement SearchBar
update Header Styling, Logo file and Typo family

mbosselmann commented 1 year ago

Hi Bennet, great job! 👍 I have two remarks:

In your wireframe the searchbar looks really small. As I know that this might not be the fixed styling for your app I want to encourage you to use the space that you have in your app
I do not understand why "Header colour changes from orange to green" is a criterion. You should describe from a user perspective why you want to mention this
otherwise you should describe the process of searching for a album

I hope this does help. Feel free to ask if you have questions. :)

benkutdev commented 1 year ago

Thank you, Mareike