Open frenck opened 1 year ago
probably fixed with PR #48 and PR #47 But right now, I am not sure about the 'value' of this integration compared to the core integration...
Comparing the entities of the Core Integration:
vs. the custom_component:
The custom component is missing the Battery Information (#45)
The Service Calls seem to be the same:
The only MAJOR difference which I can see, are the attributes for the Binary_sensor of the pet.
Core-Integration:
Custom-Component:
fixed with #59
This custom integration uses deprecated
DEVICE_CLASS_*
constants in its codebase.The
DEVICE_CLASS_*
constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.For example, for the device classes supported by the
sensor
platform, there is now aSensorDeviceClass
enum. So if a sensor previously used theDEVICE_CLASS_ENERGY
constant, it should now useSensorDeviceClass.ENERGY
. Other platforms (likebinary_sensor
, andnumber
) provide similar enumerations for their supported device classes.The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.
If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!
Kindest regards,
../Frenck