search

benleb / surepy

🐾 Library & CLI to monitor and control the Pet Door & Cat Flap Connect 🚪 the Pet Feeder Connect 🍽 and the Felaqua 💦 sold by Sure Petcare
https://pypi.org/project/surepy/
MIT License
76 stars 36 forks source link

Fixed issue with non-working unlock #153

Closed czandee closed 1 year ago

czandee commented 1 year ago

Hi

The command surepy locking -d <id> -m unlock would not work (at least in my system). Because of the if lock_state: in the CLI locking command method which always resolves to false when 0 (and 0 is the enum value of unlock).

So the only change I suggest to fix this is to remove the if lock_state: condition completely - this condition is superfluous because the assignment block above makes sure that either lock_state has a reasonable value or returns otherwise. Another possibility would be to write if lock_state in LockState: which would make (doubly) sure that lock_state has a valid value.

Best regards, Chris

czandee commented 1 year ago

Sorry, should have created PR from a feature branch, only the frist commit should be part of this PR. I'm closing this PR and possibly reopen from a feature branch.