Node package isn't currently importable

[deontologician]

Right now it fails because the package.json specifies index.js as the main file, which doesn't exist. It also uses a global variable Rx, instead of requiring it so creating a simple index.js that points to one of the files in the dist/ directory doesn't work either.

I don't know what the best way of fixing this might be. I'd suggest requiring Rx directly, but I'm not familiar with Broccoli, so maybe there's some better way to handle this

[deontologician]

Also getting this:

DEPRECATION: Brocfile.js has been deprecated in favor of ember-cli-build.js. Please see the transition guide: https://github.com/ember-cli/ember-cli/blob/master/TRANSITION.md#user-content-brocfile-transition.

[vidakovic]

+1

[jayphelps]

FYI this is mostly being neglected because major work has been going on for the new version of RxJS, v5. https://github.com/ReactiveX/rxjs (note: this is a totally different repo than https://github.com/Reactive-Extensions/RxJS)

So RxSocketSubject needs to be ported over to v5, and along the way needs to move away from Broccoli build to probably webpack. While I can't speak for @blesh, since he's on my team I can guess that this upgrade isn't likely to happen by us until we really need it to happen; which we totally will, just not right now. That's the unfortunate reality of needing to prioritize the many things we juggle.

If someone is adventurous, PRs are, as always, welcome but we understand if no one can either.

[huan]

I'm looking for a good solution for RxJS-ed WebSocket this week, even want to write by myself if there's no good one meet my requirement.

Luckily I found RxSocketSubject here, it almost implemented everything I want, like:

1. socket.subscribe()
2. socket.next()
3. auto-reconnect
4. multiplexing
5. etc.

However, it's still RxJS 4. I'd like to rewrite to RxJS 5 with TypeScript. If so, would you like to accept PR like this? Because I also like the npm module name rx-socket-subject. ;-)

Thanks for writing this awesome module! @benlesh @jayphelps Looking forward to your reply.

[deontologician]

Hey, just FYI, RxSocketSubject was already incorporated directly into rxjs 5. https://github.com/ReactiveX/rxjs/blob/master/src/observable/dom/WebSocketSubject.ts

On Wed, May 3, 2017, 00:59 Huan LI notifications@github.com wrote:

I'm looking for a good solution for RxJS-ed WebSocket this week, even want to write by myself if there's no good one meet my requirement.

Luckily I found RxSocketSubject here, it almost implemented everything I want, like:

1. socket.subscribe()
2. socket.next()
3. auto-reconnect
4. multiplexing
5. etc.

However, it's still RxJS 4. I'd like to rewrite to RxJS 5 with TypeScript. If so, would you like to accept PR like this? Because I also like the npm module name rx-socket-subject. ;-)

Thanks for writing this awesome module! @benlesh https://github.com/benlesh @jayphelps https://github.com/jayphelps Looking forward to your reply.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/benlesh/RxSocketSubject/issues/10#issuecomment-298845690, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFVtWqQXyaEOlSgVprS4I5AUE8teBZks5r2DPOgaJpZM4HML8X .

[deontologician]

(and this repo is basically dead)

On Wed, May 3, 2017, 09:23 Josh Kuhn deontologician@gmail.com wrote:

Hey, just FYI, RxSocketSubject was already incorporated directly into rxjs 5.

https://github.com/ReactiveX/rxjs/blob/master/src/observable/dom/WebSocketSubject.ts

On Wed, May 3, 2017, 00:59 Huan LI notifications@github.com wrote:

I'm looking for a good solution for RxJS-ed WebSocket this week, even want to write by myself if there's no good one meet my requirement.

Luckily I found RxSocketSubject here, it almost implemented everything I want, like:

1. socket.subscribe()
2. socket.next()
3. auto-reconnect
4. multiplexing
5. etc.

However, it's still RxJS 4. I'd like to rewrite to RxJS 5 with TypeScript. If so, would you like to accept PR like this? Because I also like the npm module name rx-socket-subject. ;-)

Thanks for writing this awesome module! @benlesh https://github.com/benlesh @jayphelps https://github.com/jayphelps Looking forward to your reply.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/benlesh/RxSocketSubject/issues/10#issuecomment-298845690, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFVtWqQXyaEOlSgVprS4I5AUE8teBZks5r2DPOgaJpZM4HML8X .

[huan]

@deontologician Wow, I will go to have a look on that.

thanks, buddy!