search

benley / bazel_rules_pex

Python PEX rules for Bazel
Apache License 2.0
39 stars 36 forks source link

prelude_bazel causes problems for other packages using this rule #67

Closed georgeliaw closed 6 years ago

georgeliaw commented 6 years ago

closing - opened by accident

benley commented 6 years ago

Interesting - I guess that's not super surprising, but I haven't seen what breaks. What have you run into?

georgeliaw commented 6 years ago

@benley It seems as of Bazel 0.10, the main project repo ends up using the prelude_bazel of packages being imported. In other words, myproject would read both its own prelude_bazel file as well as that of bazel_rules_pex.

There's a PR opened for this by @flaub at https://github.com/benley/bazel_rules_pex/pull/66 where you can see the issue at hand so I didn't want to duplicate work (this PR just had what I did in my fork to workaround this but didn't account for the tests you have setup).

benley commented 6 years ago

ah cool, thanks. I've been neglecting this repo for a bit and need to catch back up...