benlilaj / gears

Automatically exported from code.google.com/p/gears
0 stars 1 forks source link

Drag/drop of files doesn't work in Chrome 5 Gears version #1009

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use latest nightly build of Chrome.
2. Open this URL: http://www.plupload.com/example_all_runtimes.php
3. Try dragging files into the Gears runtime.
4. Notice that this doesn't work in Chrome 5 but works in Chrome 4.

What is the expected output? What do you see instead?
I expect the files to be added. It does nothing to the files now.

What version of the product are you using? On what operating system?
The Gears version shipped with Chrome 5.

Please provide any additional information below.

Original issue reported on code.google.com by spo...@gmail.com on 13 Mar 2010 at 7:09

GoogleCodeExporter commented 9 years ago
Regression occurred at http://trac.webkit.org/changeset/53296.

That change removed some IE compatability code, wherein, if the dragenter
or dragover handling called preventDefault() but did not set a dropEffect
then the browser would select an appropriate dropEffect.

With that code removed, preventDefault() was not enough to allow the drop
event because the default dropEffect was set to 'none'.  Chrome 5.0.342.3
includes this change.  Pupload calls preventDefault(), but does not set a
dropEffect, so no drop event is generated:

  http://github.com/moxiecode/plupload/blob/master/src/javascript/plupload.gears.js#L91

This regression was fixed on http://trac.webkit.org/changeset/55977 but I
recommend you use the gears desktop.setDropEffect() to better control the
dropEffect cross-browser.  There is an example here:

  http://code.google.com/p/gears/source/detail?r=3425

and that example works fine on Chrome 5.0.342.3.

Original comment by gears.te...@gmail.com on 15 Mar 2010 at 1:18

GoogleCodeExporter commented 9 years ago
I added the dropEffect call and confirmed that this is now working correctly in
latest nightly.

Original comment by spo...@gmail.com on 22 Mar 2010 at 2:39

GoogleCodeExporter commented 9 years ago

Original comment by gears.te...@gmail.com on 23 Mar 2010 at 2:15