search

benlucchesi / grails-cookie-session

cookie sessions for grails applications
28 stars 32 forks source link

Avoid aggressively creating sessions. #12

Closed jfaissolle closed 11 years ago

jfaissolle commented 11 years ago

Hello,

my current project involves both UIs with sessions and back-end session-less web services. I would like to avoid creating sessions (and the unneeded cookie exchange) when not necessary. I have modified the code so that it does not create a session upfront. This makes the plugin sessions behave as "classical" sessions.

I have tested the changes with the test-cookie-session-plugin.

Anyway, thanks a lot for this great plugin.

Regards, Julien

benlucchesi commented 11 years ago

Hi Julien,

Looks like a great contribution! Thanks for taking the time to contribute. I need to create some tests that verify the behavior before I merge the changes and republish the plugin. Once I do, I'll notify you so you can install from the plugin reno if you choose to do so.

thanks!

Ben Lucchesi | Chief Software Architect | Granicus Inc. 600 Harrison Street, Suite 120 San Francisco, CA 94107 work: 415.357.3618 x1300 | fax: 415.618.0102 | cell: 775.250.3396

From: Julien Faissolle [notifications@github.com] Sent: Monday, April 15, 2013 12:30 AM To: benlucchesi/grails-cookie-session-v2 Subject: [grails-cookie-session-v2] Avoid aggressively creating sessions. (#12)

Hello,

my current project involves both UIs with sessions and back-end session-less web services. I would like to avoid creating sessions (and the unneeded cookie exchange) when not necessary. I have modified the code so that it does not create a session upfront. This makes the plugin sessions behave as "classical" sessions.

I have tested the changes with the test-cookie-session-plugin.

Anyway, thanks a lot for this great plugin.

Regards, Julien

You can merge this Pull Request by running

git pull https://github.com/jfaissolle/grails-cookie-session-v2 develop

Or view, comment on, or merge it at:

https://github.com/benlucchesi/grails-cookie-session-v2/pull/12

Commit Summary

File Changes

Patch Links:

benlucchesi commented 11 years ago

Hi Julien,

Thanks for the contribution - it works great! Your changes have been incorporated in version 2.0.8 of the plugin. Note - 2.0.8 wasn't released to the central repository, but 2.0.9 was. So if you want to update references to the plugin from the central repo, use 2.0.9. If you run into ANY problems with the plugin please let me know.

thanks, -ben