search

benlucchesi / grails-cookie-session

cookie sessions for grails applications
28 stars 32 forks source link

Call saveSession() before sendError() is called #33

Closed sodarfish closed 10 years ago

sodarfish commented 10 years ago

HttpServletResponse.sendError() will cause response to be commited, once the response is committed, cookies can not be written to the client.

so we should override sendError() of SessionRepositoryResponseWrapper

benlucchesi commented 10 years ago

Hi Chang,

Great catch. I have some other updates that I need to roll out, including grails 2.3+ compatibility. I'll get this one in there too.

thanks,

Ben Lucchesi | Chief Software Architect Granicus, Inc.work: 415.357.3618 x1300 [X]http://www.granicus.com/ Follow Us! Bloghttp://blog.granicus.com/ | Twitterhttp://twitter.com/granicus | Facebookhttp://www.facebook.com/pages/Granicus/134633056573520

From: chang wen [notifications@github.com] Sent: Monday, February 10, 2014 3:27 AM To: benlucchesi/grails-cookie-session-v2 Subject: [grails-cookie-session-v2] Call saveSession() before sendError() is called (#33)

HttpServletResponse.sendError() will cause response to be commited, once the response is committed, cookies can not be written to the client.

so we should override sendError() of SessionRepositoryResponseWrapper

— Reply to this email directly or view it on GitHubhttps://github.com/benlucchesi/grails-cookie-session-v2/issues/33.

benlucchesi commented 10 years ago

Hi Chang,

Just letting you know that this issue is resolved in release 2.0.14.

thanks, -ben

sodarfish commented 10 years ago

good job! :)