benlucchesi
commented
10 years ago The tests are run against multiple version of grails and with a myriad of configuration options between the tests - http vs https, spring security plugin v1 vs spring security plugin v2. They were kept out of the plugin repo to limit the number of changes that needed to be made to the cookie-session plugin config. I've started to separate out the different test configurations into different branches in the test-cookie-session-plugin repo to bring some organization to it.
Ben Lucchesi | Chief Software Architect Granicus, Inc.work: 415.357.3618 x1300 [X]http://www.granicus.com/ Follow Us! Bloghttp://blog.granicus.com/ | Twitterhttp://twitter.com/granicus | Facebookhttp://www.facebook.com/pages/Granicus/134633056573520
From: Rob Zienert [notifications@github.com] Sent: Wednesday, March 19, 2014 10:28 AM To: benlucchesi/grails-cookie-session-v2 Subject: [grails-cookie-session-v2] Merge tests into the main repository (#38)
It's difficult to vet changes made to the repository when the tests are in a separate repository; and likely a barrier to other potential contributors as well. It'd help quite a lot if the tests repo were merged into this one so it all lives in one place. Was there a technical reason for splitting it apart?
— Reply to this email directly or view it on GitHubhttps://github.com/benlucchesi/grails-cookie-session-v2/issues/38.
robzienert
double16
It's difficult to vet changes made to the repository when the tests are in a separate repository; and likely a barrier to other potential contributors as well. It'd help quite a lot if the tests repo were merged into this one so it all lives in one place. Was there a technical reason for splitting it apart?