search

benlucchesi / grails-cookie-session

cookie sessions for grails applications
28 stars 32 forks source link

Support for Tomcat6 #39

Closed EduardoSolanas closed 10 years ago

EduardoSolanas commented 10 years ago

Hi would be difficult to add support for Tomcat6 ? Right know I have a null pointer error in the file CookieSessionRepository.groovy at the line 552 when doing: c.httpOnly = httpOnly

Apparently httpOnly property is only available in Tomcat7 and not Tomcat6, do you want to add support for tomcat6 ?

Thanks

benlucchesi commented 10 years ago

This shouldn't be a problem at all. Sorry about the inconvenience - I didn't even think to check for Tomcat 6 compatibility.

Just out of curiosity, why are you still on tomcat 6? I'm asking to get a better understanding of the environments that cookie-session is being used in.

I'll probably be able to get a build out in the next few weeks that addresses this, but in the meantime, have you been able to build a local version that fixes this?

Ben Lucchesi | Chief Software Architect Granicus, Inc.work: 415.357.3618 x1300 [X]http://www.granicus.com/ Follow Us! Bloghttp://blog.granicus.com/ | Twitterhttp://twitter.com/granicus | Facebookhttp://www.facebook.com/pages/Granicus/134633056573520

From: belcebuu [notifications@github.com] Sent: Sunday, May 04, 2014 4:20 AM To: benlucchesi/grails-cookie-session-v2 Subject: [grails-cookie-session-v2] Support for Tomcat6 (#39)

Hi would be difficult to add support for Tomcat6 ? Right know I have a null pointer error in the file CookieSessionRepository.groovy at the line 552 when doing: c.httpOnly = httpOnly

Apparently httpOnly property is only available in Tomcat7 and not Tomcat6, do you want to add support for tomcat6 ?

Thanks

— Reply to this email directly or view it on GitHubhttps://github.com/benlucchesi/grails-cookie-session-v2/issues/39.

EduardoSolanas commented 10 years ago

Hi Ben,

Well I know it is strange, in my company the deployment cloud uses a fork of an old cloudfoundry version, now they are updating it but it would be done probably next year, minewhile we are stucked in tomcat6, dev-ops are 100% working in the new cloud.

We haven't build anything yet, our target is to have a seamless deployment environment but it is a nice to have, we don't have time for this at the moment.

Thanks a lot

benlucchesi commented 10 years ago

sorry this took so long... got it implemented though. trying installing 2.0.15 and let me know how it goes.

EduardoSolanas commented 10 years ago

Sorry for the late response we have been very busy, I will test it thanks very much.

Good news is that we will have tomcat 7 soon but it is always nice to have wider tomcat version support :)